Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up SwiftUI/Onboarding screens #6139

Merged
merged 5 commits into from
May 11, 2022
Merged

Tidy up SwiftUI/Onboarding screens #6139

merged 5 commits into from
May 11, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented May 10, 2022

This PR touches a lot of files, and is probably easier to review the commits in order. They do as follows:

  • Drops all iOS 13/14 availability checks across the onboarding flow and templates.
  • Simplifies the FontValues struct
  • Fixes alignment and truncating of localised strings on the Use Case screen on small devices.
  • Uses the readableFrame modifier and OnboardingIconImage in the places that were using standard view modifiers.

Note: The last step to follow on the Use Case screen will hopefully be adding a blur to the footer when there is content behind it in a similar style to a navigation/tab bar.

Use case screen top Use case screen bottom
Simulator Screen Shot - iPod touch (7th generation) - 2022-05-10 at 15 50 52 Simulator Screen Shot - iPod touch (7th generation) - 2022-05-10 at 15 50 55

@pixlwave pixlwave requested review from a team, Anderas and gileluard and removed request for a team May 10, 2022 15:01
@pixlwave pixlwave marked this pull request as ready for review May 10, 2022 15:07
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zbwPvX

@pixlwave pixlwave requested review from a team and SBiOSoftWhare and removed request for gileluard and a team May 11, 2022 07:35
Copy link
Contributor

@Anderas Anderas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spring clean

Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup!

@pixlwave pixlwave merged commit 8309eea into develop May 11, 2022
@pixlwave pixlwave deleted the doug/swiftui_tidyup branch May 11, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants