Display redacted messages in the timeline #6272
Conversation
aringenbach
requested review from
a team,
pixlwave and
phloux
and removed request for
a team
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/MXswkL |
|
I added a setting as well under interface to toggle on or off this feature (similar to Andro/Web) Sidenote: I suppose once we want to move Bubbles/Threads/Show Latest Avatar out of Labs they could all go well together in a dedicated Timeline section. |
There was a problem hiding this comment.
Sidenote: I suppose once we want to move Bubbles/Threads/Show Latest Avatar out of Labs they could all go well together in a dedicated Timeline section.
That sounds sensible. Although now that we can use SwiftUI for all of our features, I wonder how much work it would be to start building new sections as simple Forms for groups of settings to closer align with Android.
Given that settings have a few minor UI bugs as well, I wonder how much it would cost to remake them entirely with SwiftUI actually. SettingsViewController is huge but it looks to me as it contains a lot of boring/repetitive code. Might be worth taking the time as it will have to be made for ElementX anyway. |
Totally! If the the time can be allocated that would be amazing. I think there was a project at some stage to redo settings, but not sure what happened to that. |
Might be a fix for #2180 (which is labelled as requiring design input). This simply reuses the same design that's currently seen when the root message of a thread is redacted.