Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: VoiceOver: Add accessibility label and hint to the Record Voice Message button. #6323

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Accessibility: VoiceOver: Add accessibility label and hint to the Record Voice Message button. #6323

merged 7 commits into from
Jun 22, 2022

Conversation

robin24
Copy link
Contributor

@robin24 robin24 commented Jun 20, 2022 •
edited
Loading

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@robin24 robin24 changed the title Add accessibility label and hint to the Record Voice Message button. Accessibility: VoiceOver: Add accessibility label and hint to the Record Voice Message button. Jun 20, 2022
@robin24
Copy link
Contributor Author

robin24 commented Jun 20, 2022

I added an accessibility label and hint to the Voice Message Record button to improve the VoiceOver experience.

Signed off by Robin Kipp [email protected]

@robin24 robin24 marked this pull request as ready for review June 20, 2022 22:46
pixlwave
pixlwave reviewed Jun 21, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robin24, thanks very much for opening this PR. I've added a couple of comments to it, but looks good to me and we very much welcome accessibility fixes like these :)

Riot/Modules/Room/VoiceMessages/VoiceMessageToolbarView.swift Outdated Show resolved Hide resolved
Riot/Modules/Room/VoiceMessages/VoiceMessageToolbarView.swift Outdated Show resolved Hide resolved
pixlwave
pixlwave requested changes Jun 21, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, a couple more changes and then I think it'll be good to merge

Riot/Assets/de.lproj/Vector.strings Outdated Show resolved Hide resolved
Riot/Assets/en.lproj/Vector.strings Outdated Show resolved Hide resolved
pixlwave
pixlwave approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @robin24, works well for me 👍

@pixlwave pixlwave merged commit 67291f8 into element-hq:develop Jun 22, 2022
@robin24
Copy link
Contributor Author

robin24 commented Jun 22, 2022

Awesome! 🎉🎉🎉
Thanks @pixlwave for all your help with my very first PR on here, very greatly appreciated 👍

stefanceriu pushed a commit that referenced this pull request Jun 28, 2022
@robin24 @stefanceriu
Accessibility: VoiceOver: Add accessibility label and hint to the Rec…
1cba963 
…ord Voice Message button. (#6323)

* Add accessibility label and hint to the Record Voice Message button.

* Add release note.

* Remove unnecessary import for SwiftUI.

* Update Riot/Modules/Room/VoiceMessages/VoiceMessageToolbarView.swift

Use VectorL10n instead of calling NSLocalizedString directly.

* Add German translation for the newly added a11y strings.

* Revert "Add German translation for the newly added a11y strings."

This reverts commit 003cfd9.

* Update Riot/Assets/en.lproj/Vector.strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robin24 @pixlwave