-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable reporting of live location shares (PSF-1066) #6326
Conversation
Signed-off-by: Johannes Marbach <[email protected]>
28ab942
to
04d3afe
Compare
Kudos, SonarCloud Quality Gate passed! |
[self presentEventForwardingDialogForSelectedEvent:selectedEvent]; | ||
}]]; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the block above because there is another if
below without !selectedEvent.location
which effectively made this a no-op.
Codecov Report
@@ Coverage Diff @@
## develop #6326 +/- ##
===========================================
- Coverage 6.24% 6.24% -0.01%
===========================================
Files 1440 1440
Lines 155412 155439 +27
Branches 62532 62541 +9
===========================================
Hits 9705 9705
- Misses 145302 145330 +28
+ Partials 405 404 -1
Continue to review full report at Codecov.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3kbqoT |
This sets the display text of
beacon_info
events which enables the context menu on live location shares which in turn allows users to report the events. Other events in the menus will be implemented separately.Pull Request Checklist