Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display mandatory backup only if session is running #6331

Conversation

aringenbach
Copy link
Contributor

This fixes an issue where failed syncs after user migration could trigger an unwanted display of the mandatory secure backup setup.

@aringenbach aringenbach force-pushed the aringenbach/display_mandatory_backup_only_if_session_is_running branch from 7d177e5 to f88c6a9 Compare June 22, 2022 13:24
@aringenbach aringenbach requested review from a team, stefanceriu, MaximeEvrard42, SBiOSoftWhare, gileluard and Anderas and removed request for a team, stefanceriu, MaximeEvrard42 and SBiOSoftWhare June 22, 2022 13:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #6331 (f88c6a9) into develop (f64b7c5) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6331      +/-   ##
===========================================
- Coverage     6.18%    6.18%   -0.01%     
===========================================
  Files         1440     1440              
  Lines       155412   155413       +1     
  Branches     62519    62520       +1     
===========================================
  Hits          9612     9612              
- Misses      145395   145396       +1     
  Partials       405      405              
Impacted Files Coverage Δ
Riot/Modules/Application/LegacyAppDelegate.m 13.68% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64b7c5...f88c6a9. Read the comment docs.

@aringenbach aringenbach requested review from pixlwave and ismailgulek and removed request for Anderas June 23, 2022 12:14
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aringenbach aringenbach merged commit ff5bbd2 into develop Jun 23, 2022
@aringenbach aringenbach deleted the aringenbach/display_mandatory_backup_only_if_session_is_running branch June 23, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants