Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent login using keyboard when homeserver is loading. #6338

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

pixlwave
Copy link
Member

Tiny bugfix I noticed whilst porting the screen over to ElementX where you could hit return whilst the service was loading a homeserver and it would attempt to login.

@pixlwave pixlwave force-pushed the doug/fix-keyboard-login branch from c4b43ab to 542dd06 Compare June 23, 2022 16:15
@pixlwave pixlwave marked this pull request as ready for review June 23, 2022 16:15
@pixlwave pixlwave requested a review from ismailgulek June 23, 2022 16:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PexDw9

@codecov-commenter
Copy link

Codecov Report

Merging #6338 (542dd06) into develop (ff5bbd2) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6338      +/-   ##
===========================================
+ Coverage     6.17%    6.19%   +0.01%     
===========================================
  Files         1440     1440              
  Lines       155100   155102       +2     
  Branches     62361    62362       +1     
===========================================
+ Hits          9584     9608      +24     
+ Misses      145113   145089      -24     
- Partials       403      405       +2     
Impacted Files Coverage Δ
...thentication/Login/AuthenticationLoginModels.swift 44.00% <0.00%> (-6.00%) ⬇️
...ication/Login/View/AuthenticationLoginScreen.swift 0.00% <0.00%> (ø)
...t/Views/RoomInputToolbar/MXKRoomInputToolbarView.m 0.00% <0.00%> (ø)
...ing/SplashScreen/View/OnboardingSplashScreen.swift 58.66% <0.00%> (+4.00%) ⬆️
...Modules/Common/ViewModel/StateStoreViewModel.swift 50.00% <0.00%> (+19.44%) ⬆️
...SplashScreen/OnboardingSplashScreenViewModel.swift 53.84% <0.00%> (+42.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5bbd2...542dd06. Read the comment docs.

@pixlwave pixlwave merged commit 13f4973 into develop Jun 23, 2022
@pixlwave pixlwave deleted the doug/fix-keyboard-login branch June 23, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants