A11y: VoiceOver: Properly end the active AVAudioSession when recording finishes, causing VO audio to be routed back to the main speaker instead of the earpiece.

[robin24]

Issue Summary

When a VoiceOver user on iPhone records a voice message in Element, all VoiceOver speech and sounds are being routed to the earpiece instead of the main speaker once recording finishes.
This is quite a severe issue, as it makes VoiceOver almost unusable.

Problem Resolution

The cause of this issue is that currently, the AVAudiosession is not being ended properly, and is thus being kept active by the OS even after voice message recording has stopped.

This PR resolves this by calling
AVAudioSession.sharedInstance().setActive(false)
when recording ends.

Pull Request Checklist

• I read the contributing guide
• UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
• Accessibility has been taken into account.

• Pull request is based on the develop branch

• Pull request contains a changelog file in ./changelog.d
• You've made a self review of your PR
• Pull request includes screenshots or videos of UI changes
• Pull request includes a sign off

[robin24]

Signed off by Robin Kipp [email protected]

[pixlwave]

Thanks for this contribution Robin, LGTM 😎
I have a feeling this fixes a few other issues too!

[stefanceriu]

Nice 👏 Thank you for fixing it!