Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Dsyms to Sentry when building Alpha #6413

Merged
merged 7 commits into from
Aug 18, 2022
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Jul 12, 2022

Automatically upload dsym files to sentry when Alpha build is produced and binary uploaded to Diawi

@Anderas Anderas requested a review from a team July 12, 2022 12:25
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #6413 (4d62ef4) into develop (0bc26de) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6413   +/-   ##
========================================
  Coverage     6.24%    6.24%           
========================================
  Files         1451     1452    +1     
  Lines       155602   155672   +70     
  Branches     62510    62548   +38     
========================================
+ Hits          9715     9723    +8     
- Misses      145480   145542   +62     
  Partials       407      407           
Impacted Files Coverage Δ
Riot/Generated/Strings.swift 2.91% <0.00%> (-0.01%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...les/Room/LocationSharing/View/MapCreditsView.swift 0.00% <0.00%> (ø)
...s/Room/LocationSharing/LocationSharingModels.swift 0.00% <0.00%> (ø)
...oom/LocationSharing/LocationSharingViewModel.swift 0.00% <0.00%> (ø)
...oom/LocationSharing/View/LocationSharingView.swift 0.00% <0.00%> (ø)
...SharingViewer/View/LiveLocationSharingViewer.swift 0.00% <0.00%> (ø)
...ingViewer/LiveLocationSharingViewerViewModel.swift 0.00% <0.00%> (ø)
...s/Room/LocationSharing/MapCreditsActionSheet.swift 0.00% <0.00%> (ø)
Riot/Modules/Pills/PillsFormatter.swift 83.33% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc26de...4d62ef4. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Anderas Anderas force-pushed the andy/sentry_fastlane branch from 503d32f to bc4ece3 Compare August 18, 2022 10:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pMWMzB

@Anderas Anderas merged commit 72485da into develop Aug 18, 2022
@Anderas Anderas deleted the andy/sentry_fastlane branch August 18, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants