Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unnecessary network breadcrumbs in Sentry #6726

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Sep 15, 2022

No description provided.

@Anderas Anderas requested a review from pixlwave September 15, 2022 15:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🙏

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 9.98% // Head: 9.96% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (515cc55) compared to base (7da6366).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6726      +/-   ##
===========================================
- Coverage     9.98%    9.96%   -0.03%     
===========================================
  Files         1484     1484              
  Lines       150502   150509       +7     
  Branches     60752    60754       +2     
===========================================
- Hits         15025    14995      -30     
- Misses      134923   134960      +37     
  Partials       554      554              
Impacted Files Coverage Δ
...iot/Modules/Analytics/SentryMonitoringClient.swift 0.00% <0.00%> (ø)
Config/CommonConfiguration.swift 85.71% <0.00%> (-5.20%) ⬇️
Riot/Managers/Call/CallPresenter.swift 1.08% <0.00%> (-5.14%) ⬇️
Riot/Modules/Application/LegacyAppDelegate.m 13.40% <0.00%> (-0.34%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
...ing/SplashScreen/View/OnboardingSplashScreen.swift 58.66% <0.00%> (+4.00%) ⬆️
...dules/Room/EmojiPicker/Data/Store/EmojiStore.swift 93.02% <0.00%> (+4.65%) ⬆️
...SplashScreen/OnboardingSplashScreenViewModel.swift 53.84% <0.00%> (+42.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/2bddhv

@Anderas Anderas merged commit dee4677 into develop Sep 16, 2022
@Anderas Anderas deleted the andy/sentry branch September 16, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants