-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendezvous service (MSC3886) and ECDH X25519 AES 256 based secure… #6806
Conversation
Codecov ReportBase: 52.10% // Head: 6.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6806 +/- ##
============================================
- Coverage 52.10% 6.05% -46.06%
============================================
Files 377 1513 +1136
Lines 14552 152561 +138009
Branches 5911 61518 +55607
============================================
+ Hits 7583 9240 +1657
- Misses 6786 142913 +136127
- Partials 183 408 +225
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AmTpCf |
4c2c8e2
to
9607500
Compare
… channel creation establishing implementation and simple tests.
83db37a
to
5b2a0cc
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It seems we can inject the RendezvousService
into the QRLoginService
and update the service state accordingly after some actions. Feel free to replace QRLoginCode with your RendezvousPayload
.
Also ftr on matrix-js-sdk it seems the payload updated with an intent: https://github.com/matrix-org/matrix-js-sdk/blob/hughns/http-rendezvous/src/rendezvous/code.ts
… channel creation establishing implementation and simple tests.
This PR implements: