Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent autolayout crashes when showing toast notifications #7046

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

stefanceriu
Copy link
Member

Prevent Unable to activate constraint with anchors .. because they have no common ancestor. crashes. Only link toasts to the top safe area instead of the navigation controller

…ave no common ancestor.` crashes. Only link toasts to the top safe area instead of the navigation controller
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 11.78% // Head: 11.78% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (52afc6d) compared to base (3c2b4a3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7046   +/-   ##
========================================
  Coverage    11.78%   11.78%           
========================================
  Files         1611     1611           
  Lines       158184   158159   -25     
  Branches     64245    64226   -19     
========================================
- Hits         18640    18638    -2     
+ Misses      138914   138892   -22     
+ Partials       630      629    -1     
Flag Coverage Δ
uitests 54.63% <ø> (+<0.01%) ⬆️
unittests 6.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Indicators/ViewPresenters/ToastViewPresenter.swift 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...es/Threads/ThreadList/Views/Cell/ThreadModel.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...serSessionsOverview/View/UserSessionListItem.swift 65.06% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanceriu stefanceriu merged commit 01714ad into develop Nov 7, 2022
@stefanceriu stefanceriu deleted the stefan/toastCrashes branch November 7, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants