Import progress for room keys #7078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/large_backups
branch
from
8eaf53e to
20668a5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Anderas
requested review from
a team and
stefanceriu
and removed request for
a team
Codecov ReportBase: 11.66% // Head: 11.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7078 +/- ##
===========================================
+ Coverage 11.66% 11.74% +0.08%
===========================================
Files 1620 1620
Lines 158997 158900 -97
Branches 64678 64611 -67
===========================================
+ Hits 18540 18669 +129
+ Misses 139816 139594 -222
+ Partials 641 637 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK change
If we are actively importing keys from backup, display the current import progress as a percentage in the settings, whilst disabling the "restore from backup" button. The import progress replaces the previously unused backup progress.
To keep the progress updating I had to add a simple 1s timer, though I don't think this works very well with the current view model architecture, as it forces the entire section to refresh, leading to visible refresh of the other button rows. In practice only the WIP Crypto V2 will trigger this behaviour, because legacy crypto always returns nil for import progress. This means we can improve the UI behaviour in a future PR