Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display sync progress on the loading screen #7101

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Nov 23, 2022

Related SDK change

Use changes in the SDK to display sync status on the launch loading screen, if the feature flag is enabled. The design is a simple copy that can be further tweaked, as the flag is currently disabled, and only enabled on Element-R builds.

Unrelatedly, change the fingerprint of Sentry issues to match the message of the issue

Syncing Processing
Simulator Screen Shot - iPhone 14 Pro - 2022-11-23 at 09 53 04 Simulator Screen Shot - iPhone 14 Pro - 2022-11-23 at 09 53 34

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 11.73% // Head: 11.73% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (fc0cf90) compared to base (8015f29).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7101      +/-   ##
===========================================
- Coverage    11.73%   11.73%   -0.01%     
===========================================
  Files         1620     1620              
  Lines       159195   159224      +29     
  Branches     64747    64761      +14     
===========================================
+ Hits         18682    18685       +3     
- Misses      139877   139903      +26     
  Partials       636      636              
Flag Coverage Δ
uitests 54.91% <ø> (+0.01%) ⬆️
unittests 5.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...iot/Modules/Analytics/SentryMonitoringClient.swift 0.00% <0.00%> (ø)
Riot/Modules/Application/LegacyAppDelegate.m 14.41% <0.00%> (-0.05%) ⬇️
...les/Authentication/AuthenticationCoordinator.swift 0.00% <0.00%> (ø)
...ation/Legacy/LegacyAuthenticationCoordinator.swift 8.28% <0.00%> (-0.05%) ⬇️
Riot/Modules/LaunchLoading/LaunchLoadingView.swift 0.00% <0.00%> (ø)
...es/LaunchLoading/LaunchLoadingViewController.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...nOverview/MockUserSessionOverviewScreenState.swift 100.00% <0.00%> (+2.75%) ⬆️
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 90.19% <0.00%> (+5.88%) ⬆️
...Sessions/Common/View/UserSessionCardViewData.swift 88.46% <0.00%> (+6.75%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a nice addition! 👏

@Anderas Anderas merged commit b14247f into develop Nov 24, 2022
@Anderas Anderas deleted the andy/sync_progress branch November 24, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants