-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich Text Editor: Design Improvements #7127
Conversation
Velin92
commented
Nov 29, 2022
•
edited
Loading
edited
- When minimised, and there is one single line, the toggle button should be more centred
- Less size for the bottom sheet custom height, have the bottom distance match the design
- Set the scrollsEnabled value to not be scrollable on iOS 16 in the ComposerActionsList:
- Change asset for the disabled plain text mode to match the on the Figma
- Move a bit upwards the + and the send button when plain text mode is enabled, so that they can be centred with the rounded rectangle (they’re just slightly below right now)
- All of the text formatting row in the bottom sheet should be tappable to change the text formatting toggle
- iOS 15 fullscreen mode not working
- Toggle looks like android, should look like iOS
- iPhone 14 better spacing in fullscreen + reply/edit mode
- Fix for 7130 issue
Codecov ReportBase: 11.73% // Head: 11.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7127 +/- ##
===========================================
+ Coverage 11.73% 11.77% +0.04%
===========================================
Files 1620 1620
Lines 159282 159354 +72
Branches 64807 64853 +46
===========================================
+ Hits 18689 18762 +73
+ Misses 139957 139953 -4
- Partials 636 639 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM