Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the voice broadcast chunks from the attachments list #7133

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Dec 2, 2022

Remove the voice broadcast chunks from the attachments list

@phloux phloux requested review from yostyle and giomfo December 2, 2022 10:52
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 11.76% // Head: 11.75% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (977d355) compared to base (f2ab29b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7133      +/-   ##
===========================================
- Coverage    11.76%   11.75%   -0.02%     
===========================================
  Files         1620     1620              
  Lines       159388   159360      -28     
  Branches     64884    64879       -5     
===========================================
- Hits         18759    18738      -21     
- Misses      139978   139984       +6     
+ Partials       651      638      -13     
Flag Coverage Δ
uitests 54.68% <ø> (-0.16%) ⬇️
unittests 5.98% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Modules/MatrixKit/Models/Room/MXKRoomDataSource.m 13.06% <0.00%> (-0.02%) ⬇️
...eateActionList/View/ComposerCreateActionList.swift 75.34% <0.00%> (-5.85%) ⬇️
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...castRecorder/View/VoiceBroadcastRecorderView.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.65% <0.00%> (+0.30%) ⬆️
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 90.19% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phloux phloux marked this pull request as ready for review December 2, 2022 13:39
@phloux phloux force-pushed the phlpro/voicebroadcast_hide_attachments branch from 8833c6d to 977d355 Compare December 2, 2022 15:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@phloux phloux merged commit 28f86a9 into develop Dec 2, 2022
@phloux phloux deleted the phlpro/voicebroadcast_hide_attachments branch December 2, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants