Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threshold for unread messages in all the spaces (PSG-944) #7140

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

alfogrillo
Copy link
Contributor

Description

This PR puts a threshold on the count of unread messages visibile in the home screen.
Currently the threshold is 999 messages/invites.

999+

@alfogrillo alfogrillo requested a review from pixlwave December 7, 2022 13:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 11.74% // Head: 11.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (83f7c70) compared to base (1efa7c1).
Patch coverage: 21.42% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7140   +/-   ##
========================================
  Coverage    11.74%   11.75%           
========================================
  Files         1621     1621           
  Lines       159428   159428           
  Branches     64922    64923    +1     
========================================
+ Hits         18732    18734    +2     
+ Misses      140058   140055    -3     
- Partials       638      639    +1     
Flag Coverage Δ
uitests 54.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Modules/Home/AllChats/AllChatsViewController.swift 29.11% <21.42%> (ø)
...Sessions/Common/View/UserSessionCardViewData.swift 87.17% <0.00%> (-1.29%) ⬇️
RiotSwiftUI/Modules/Common/Mock/ScreenList.swift 90.19% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌
Sorry for the delay, I must have missed this when it was assigned.

@amshakal
Copy link

LGTM as well :)

@alfogrillo alfogrillo merged commit 7170daa into develop Dec 13, 2022
@alfogrillo alfogrillo deleted the alfogrillo/badge_threshold branch December 13, 2022 12:38
@alfogrillo alfogrillo changed the title Add threshold for unread messages in all the spaces Add threshold for unread messages in all the spaces (PSG-944) Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants