Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoiceBroadcast: Add backward and forward buttons for playback #7146

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Dec 8, 2022

Add Voice Broadcast backward and forward buttons for playback.

@phloux phloux requested a review from yostyle December 8, 2022 14:35
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 11.74% // Head: 11.74% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b579ad6) compared to base (1efa7c1).
Patch coverage: 1.29% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7146      +/-   ##
===========================================
- Coverage    11.74%   11.74%   -0.01%     
===========================================
  Files         1621     1621              
  Lines       159428   159522      +94     
  Branches     64922    64975      +53     
===========================================
+ Hits         18732    18743      +11     
- Misses      140058   140140      +82     
- Partials       638      639       +1     
Flag Coverage Δ
unittests 5.98% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ck/MatrixSDK/VoiceBroadcastPlaybackViewModel.swift 0.00% <0.00%> (ø)
...castPlayback/View/VoiceBroadcastPlaybackView.swift 0.00% <0.00%> (ø)
...stPlayback/VoiceBroadcastPlaybackScreenState.swift 100.00% <100.00%> (ø)
...Sessions/Common/View/UserSessionCardViewData.swift 87.17% <0.00%> (-1.29%) ⬇️
...Modules/Home/AllChats/AllChatsViewController.swift 28.81% <0.00%> (-0.31%) ⬇️
...ogin/Common/Service/MatrixSDK/QRLoginService.swift 7.28% <0.00%> (-0.27%) ⬇️
...t/Managers/UISIAutoReporter/UISIAutoReporter.swift 20.62% <0.00%> (-0.13%) ⬇️
.../Modules/MatrixKit/Models/Room/MXKRoomDataSource.m 13.01% <0.00%> (-0.05%) ⬇️
...ecorations/Threads/Summary/ThreadSummaryView.swift 0.00% <0.00%> (ø)
Riot/Managers/Settings/RiotSettings.swift 88.42% <0.00%> (+0.09%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phloux phloux marked this pull request as ready for review December 8, 2022 15:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phloux phloux requested review from yostyle and giomfo December 13, 2022 14:15
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phloux phloux merged commit 34159cb into develop Dec 14, 2022
@phloux phloux deleted the phlpro/voice_broadcast_backward_forward branch December 14, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants