Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX fixes on device manager after design review (PSG-1100) #7180

Merged
merged 26 commits into from
Dec 19, 2022

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Dec 16, 2022

Description

This PR makes small changes on the UI/UX to conform the device manager to the design.

@alfogrillo alfogrillo changed the title UI/UX fixes on device manager after design review UI/UX fixes on device manager after design review (PSG-1100) Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 11.83% // Head: 11.85% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (8a4aec2) compared to base (2a80735).
Patch coverage: 82.17% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7180      +/-   ##
===========================================
+ Coverage    11.83%   11.85%   +0.02%     
===========================================
  Files         1628     1628              
  Lines       159946   159983      +37     
  Branches     65179    65310     +131     
===========================================
+ Hits         18924    18961      +37     
- Misses      140384   140385       +1     
+ Partials       638      637       -1     
Flag Coverage Δ
uitests 54.84% <82.17%> (+0.10%) ⬆️
unittests 5.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...herSessions/View/UserOtherSessionsHeaderView.swift 52.83% <ø> (-0.88%) ⬇️
...UserSessionOverview/View/UserSessionOverview.swift 75.00% <68.42%> (+0.28%) ⬆️
...UserSessions/Common/View/UserSessionCardView.swift 56.73% <75.00%> (+5.98%) ⬆️
...ons/UserOtherSessions/View/UserOtherSessions.swift 84.61% <75.00%> (ø)
...ionsOverview/View/SecurityRecommendationCard.swift 82.60% <77.77%> (-0.25%) ⬇️
...erSessionsOverview/View/UserSessionsOverview.swift 77.94% <85.71%> (+0.11%) ⬆️
...es/UserSessions/Common/View/DeviceAvatarView.swift 51.02% <100.00%> (+1.02%) ⬆️
...dules/UserSessions/Common/View/SeparatorLine.swift 100.00% <100.00%> (ø)
...rOtherSessions/View/UserOtherSessionsToolbar.swift 89.74% <100.00%> (+0.13%) ⬆️
...s/UserSessionDetails/View/UserSessionDetails.swift 86.11% <100.00%> (+0.39%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo merged commit c758d35 into develop Dec 19, 2022
@alfogrillo alfogrillo deleted the alfogrillo/design_review_fixes branch December 19, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants