Fix hidden live location timeline tiles after text messages (PSG-1082) #7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents `MXEventTypeBeaconInfo` events from being added into other bubble cell data objects. Previously, when starting a live location share right after sending a text message, the beacon info event would get appended into the text message's bubble cell data which prevented it from rendering. Similarly, when restarting the app in such a situation the events would be getting reprocessed _in backwards order_ which meant the final beacon info landed in its own bubble cell data (causing it to render) but a beacon info right before the text message would now get combined with the text message causing it to go hidden.
Johennes
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 11.82% // Head: 11.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7220 +/- ##
===========================================
+ Coverage 11.82% 11.83% +0.01%
===========================================
Files 1629 1629
Lines 160207 160156 -51
Branches 65400 65379 -21
===========================================
+ Hits 18945 18961 +16
+ Misses 140621 140558 -63
+ Partials 641 637 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
MXEventTypeBeaconInfoevents from being added into other bubble cell data objects.Previously, when starting a live location share right after sending a text message, the beacon info event would get appended into the text message's bubble cell data which prevented it from rendering.
Similarly, when restarting the app in such a situation the events would be getting reprocessed in backwards order which meant the final beacon info landed in its own bubble cell data (causing it to render) but a beacon info right before the text message would now get combined with the text message causing it to go hidden.
To reproduce: