Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle VoIP buttons when VB is used #7225

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

phloux
Copy link
Contributor

@phloux phloux commented Jan 4, 2023

Handle VoIP buttons when VB is used

@phloux phloux requested review from giomfo, yostyle and nimau January 4, 2023 07:18
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 11.83% // Head: 11.83% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e54e25c) compared to base (4cb21f7).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7225      +/-   ##
===========================================
- Coverage    11.83%   11.83%   -0.01%     
===========================================
  Files         1630     1630              
  Lines       160285   160303      +18     
  Branches     65453    65462       +9     
===========================================
- Hits         18969    18967       -2     
- Misses      140678   140698      +20     
  Partials       638      638              
Flag Coverage Δ
uitests 54.85% <ø> (+<0.01%) ⬆️
unittests 5.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...oordinator/VoiceBroadcastRecorderCoordinator.swift 0.00% <0.00%> (ø)
...r/Coordinator/VoiceBroadcastRecorderProvider.swift 0.00% <0.00%> (ø)
...vice/MatrixSDK/VoiceBroadcastRecorderService.swift 0.00% <0.00%> (ø)
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
...heet/SpaceSelector/View/SpaceSelectorListRow.swift 74.68% <0.00%> (+3.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phloux phloux marked this pull request as ready for review January 4, 2023 08:03
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I let @giomfo to test it.

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle force-pushed the phlpro/voice_broadcast_voip_buttons branch from 68757df to e54e25c Compare January 10, 2023 13:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yostyle yostyle changed the title VoiceBroadcast: Handle VoIP buttons when VB is used Handle VoIP buttons when VB is used Jan 10, 2023
@yostyle yostyle merged commit b8465eb into develop Jan 10, 2023
@yostyle yostyle deleted the phlpro/voice_broadcast_voip_buttons branch January 10, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants