Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render poll ended event in the timeline (PSG-196) #7231

Merged
merged 13 commits into from
Jan 10, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Jan 4, 2023

Description

This PR renders a poll in the timeline whenever a poll ended event arrives.
Users should be able to reply to this kind of events as well.

Dependencies

matrix-org/matrix-ios-sdk#1674

Result

@alfogrillo alfogrillo requested review from a team and gileluard and removed request for a team January 4, 2023 14:30
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 11.83% // Head: 11.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (69b59f4) compared to base (7537ecd).
Patch coverage: 18.96% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7231   +/-   ##
========================================
  Coverage    11.83%   11.84%           
========================================
  Files         1630     1630           
  Lines       160255   160326   +71     
  Branches     65439    65497   +58     
========================================
+ Hits         18969    18984   +15     
- Misses      140648   140703   +55     
- Partials       638      639    +1     
Flag Coverage Δ
uitests 54.87% <58.33%> (+0.02%) ⬆️
unittests 5.96% <6.89%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Categories/MXEvent.swift 0.00% <0.00%> (ø)
.../Modules/MatrixKit/Models/Room/MXKRoomDataSource.m 12.98% <0.00%> (ø)
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 17.15% <0.00%> (-0.13%) ⬇️
Riot/Modules/Room/CellData/RoomBubbleCellData.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...eCells/Styles/Plain/Cells/Poll/PollPlainCell.swift 0.00% <0.00%> (ø)
...linePoll/Coordinator/TimelinePollCoordinator.swift 0.00% <0.00%> (ø)
...imelinePoll/Coordinator/TimelinePollProvider.swift 0.00% <0.00%> (ø)
...linePoll/View/TimelinePollAnswerOptionButton.swift 53.71% <0.00%> (-0.45%) ⬇️
...ules/Room/TimelinePoll/View/TimelinePollView.swift 68.49% <33.33%> (-3.15%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to update TimelinePollViewModelTests.swift but otherwise lgtm

@alfogrillo alfogrillo force-pushed the alfogrillo/render_poll_end_event branch from 9d0c069 to 69b59f4 Compare January 10, 2023 11:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo merged commit fb046b2 into develop Jan 10, 2023
@alfogrillo alfogrillo deleted the alfogrillo/render_poll_end_event branch January 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants