-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render poll ended event in the timeline (PSG-196) #7231
Conversation
Codecov ReportBase: 11.83% // Head: 11.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7231 +/- ##
========================================
Coverage 11.83% 11.84%
========================================
Files 1630 1630
Lines 160255 160326 +71
Branches 65439 65497 +58
========================================
+ Hits 18969 18984 +15
- Misses 140648 140703 +55
- Partials 638 639 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to update TimelinePollViewModelTests.swift
but otherwise lgtm
9d0c069
to
69b59f4
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
This PR renders a poll in the timeline whenever a poll ended event arrives.
Users should be able to reply to this kind of events as well.
Dependencies
matrix-org/matrix-ios-sdk#1674
Result