Fix crash related to the avatar service dependency (PSG-1140)

[alfogrillo]

A crash is being reported in the DependencyContainer which wasn't able to resolve the AvatarServiceProtocol.

This PR refactors the code by changing the dependency injection mechanism for the AvatarServiceProtocol.
In particular now the AvatarViewModel is injected in an AvatarImage by using SwiftUI's environment objects.

This architecture is still flexible enough to allow injection of a mocked avatar service.

Since we used the custom DependencyContainer DI mechanism just for this case, I deleted it completely from the project.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Base: 11.85% // Head: 11.83% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3696e38) compared to base (3284437).
Patch coverage: 43.07% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7268      +/-   ##
===========================================
- Coverage    11.85%   11.83%   -0.02%     
===========================================
  Files         1628     1624       -4     
  Lines       160325   160296      -29     
  Branches     65507    65518      +11     
===========================================
- Hits         19001    18977      -24     
+ Misses      140685   140680       -5     
  Partials       639      639              

Flag	Coverage Δ
uitests	54.85% <71.79%> (-0.04%)	⬇️
unittests	5.97% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ommon/Avatar/Service/MatrixSDK/AvatarService.swift	0.00% <ø> (ø)
...es/Common/InfoSheet/MockInfoSheetScreenState.swift	0.00% <0.00%> (ø)
...dinator/LiveLocationSharingViewerCoordinator.swift	0.00% <0.00%> (ø)
...aring/Coordinator/LocationSharingCoordinator.swift	0.00% <0.00%> (ø)
...Coordinator/StaticLocationViewingCoordinator.swift	0.00% <0.00%> (ø)
...rdinator/RoomNotificationSettingsCoordinator.swift	0.00% <0.00%> (ø)
...cationSettings/View/RoomNotificationSettings.swift	0.00% <0.00%> (ø)
...Settings/View/RoomNotificationSettingsHeader.swift	0.00% <0.00%> (ø)
...omUpgrade/Coordinator/RoomUpgradeCoordinator.swift	0.00% <0.00%> (ø)
...estion/Coordinator/UserSuggestionCoordinator.swift	0.00% <0.00%> (ø)
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Anderas]

Makes sense to use environmentObject as native solution in SwiftUI for this, though I am generally cautions when it comes to this type of dependency injection (compared to say initializer dependency injection) - it is all too easy to forget it at one place, causing a crash. It sounds good for mocks and previews though