Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Past poll history UI (PSG-1027) #7278

Merged
merged 5 commits into from
Jan 18, 2023
Merged

Conversation

alfogrillo
Copy link
Contributor

Description

This pr adds the UI for rendering ended polls in the "past polls" tab.

Notes

  • The UI is currently populated with mocked data
  • Because of the above model objects are likely going to change

Result

@alfogrillo alfogrillo requested review from a team and aringenbach and removed request for a team January 17, 2023 16:43
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Base: 11.92% // Head: 11.97% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (01baa07) compared to base (a9ff128).
Patch coverage: 80.17% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7278      +/-   ##
===========================================
+ Coverage    11.92%   11.97%   +0.05%     
===========================================
  Files         1633     1633              
  Lines       160744   160909     +165     
  Branches     65700    65802     +102     
===========================================
+ Hits         19163    19272     +109     
- Misses      140942   140997      +55     
- Partials       639      640       +1     
Flag Coverage Δ
uitests 55.40% <80.17%> (+0.17%) ⬆️
unittests 5.95% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...UI/Modules/Room/PollHistory/View/PollHistory.swift 88.40% <33.33%> (-2.51%) ⬇️
...I/Modules/Room/PollHistory/View/PollListItem.swift 79.24% <72.60%> (-12.43%) ⬇️
...odules/Room/PollHistory/PollHistoryViewModel.swift 92.85% <94.11%> (+0.54%) ⬆️
.../Room/PollHistory/MockPollHistoryScreenState.swift 100.00% <100.00%> (ø)
...I/Modules/Room/PollHistory/PollHistoryModels.swift 100.00% <100.00%> (ø)
...lHistory/Service/Mock/MockPollHistoryService.swift 100.00% <100.00%> (ø)
...ingViewer/LiveLocationSharingViewerViewModel.swift 52.63% <0.00%> (-1.76%) ⬇️
...ojiPicker/Data/EmojiMart/EmojiItem+EmojiMart.swift 95.34% <0.00%> (-0.31%) ⬇️
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
...cast/VoiceBroadcastSDK/VoiceBroadcastService.swift 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment inline, otherwise LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alfogrillo alfogrillo merged commit be2e153 into develop Jan 18, 2023
@alfogrillo alfogrillo deleted the alfogrillo/past_poll_history branch January 18, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants