Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display migration progress during startup #7286

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Jan 18, 2023

Related SDK change

Display progress for the newly added migratingData stage during session startup that is shown on the loading page

Loading
Simulator Screen Shot - iPhone 14 Pro - 2023-01-18 at 16 41 06

@Anderas Anderas force-pushed the andy/large_accounts branch from db01956 to 9480bb7 Compare January 18, 2023 16:45
@Anderas Anderas requested review from a team and phloux and removed request for a team January 18, 2023 16:45
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (andy/migrate_crypto@f098e77). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             andy/migrate_crypto    #7286   +/-   ##
======================================================
  Coverage                       ?   11.85%           
======================================================
  Files                          ?     1628           
  Lines                          ?   160385           
  Branches                       ?    65528           
======================================================
  Hits                           ?    19006           
  Misses                         ?   140739           
  Partials                       ?      640           
Flag Coverage Δ
uitests 54.90% <0.00%> (?)
unittests 5.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@phloux phloux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anderas Anderas merged commit e772556 into andy/migrate_crypto Jan 23, 2023
@Anderas Anderas deleted the andy/large_accounts branch January 23, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants