Ensure E2EE never tracks UnknownError #7304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/tracking_changes
branch
from
da4b6c3 to
5a5ac20
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Anderas
commented
Jan 26, 2023
Anderas
force-pushed
the
andy/tracking_changes
branch
from
5a5ac20 to
3e286d1
Compare
Codecov ReportBase: 11.97% // Head: 11.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## hotfix/1.9.16 #7304 +/- ##
=================================================
- Coverage 11.97% 11.97% -0.01%
=================================================
Files 1634 1634
Lines 161034 161031 -3
Branches 65131 65124 -7
=================================================
- Hits 19291 19288 -3
Misses 141101 141101
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using
UnknownErroranalytics event to track some types of E2EE errors. This error type is however used for other unrelated events as well (notably VOIP), which makes it impossible to distinguish the area of concern.To solve this we will never use the generic
UnknownErrorto track E2EE errors and instead only rely on the existingOlmUnspecifiedError(even if the "Olm" in the name is misleading). Further details about the error are always present in thecontextproperty