-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location centring user's sharing location #7398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...I/Modules/LocationSharing/LiveLocationSharingViewer/LiveLocationSharingViewerViewModel.swift
Show resolved
Hide resolved
RiotSwiftUI/Modules/LocationSharing/MapView/View/LocationSharingMapView.swift
Show resolved
Hide resolved
RiotSwiftUI/Modules/LocationSharing/MapView/View/LocationSharingMapView.swift
Show resolved
Hide resolved
RiotSwiftUI/Modules/LocationSharing/MapView/View/LocationSharingMapView.swift
Show resolved
Hide resolved
RiotSwiftUI/Modules/LocationSharing/StartLocationSharing/LocationSharingModels.swift
Show resolved
Hide resolved
...ationSharing/StaticLocationSharingViewer/Test/Unit/StaticLocationViewingViewModelTests.swift
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7398 +/- ##
========================================
Coverage 12.15% 12.16%
========================================
Files 1643 1643
Lines 162265 162293 +28
Branches 66630 66640 +10
========================================
+ Hits 19729 19739 +10
- Misses 141890 141909 +19
+ Partials 646 645 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...I/Modules/LocationSharing/LiveLocationSharingViewer/LiveLocationSharingViewerViewModel.swift
Outdated
Show resolved
Hide resolved
…LiveLocationSharingViewerViewModel.swift Co-authored-by: Alfonso Grillo <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Fixes bug about centring user in live location sharing