-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display upgrade verification prompt #7454
Conversation
6293386
to
532278e
Compare
532278e
to
312ab93
Compare
312ab93
to
bff0b28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I fully understand how this works - I don't see where showVerificationUpgradeAlert
gets set back to true
and when it would get set back to false
after an alert. But the code looks fine to me.
if | ||
let feature = MXSDKOptions.sharedInstance().cryptoSDKFeature, | ||
feature.isEnabled && feature.needsVerificationUpgrade | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be more inline with the project's style:
if | |
let feature = MXSDKOptions.sharedInstance().cryptoSDKFeature, | |
feature.isEnabled && feature.needsVerificationUpgrade | |
{ | |
if let feature = MXSDKOptions.sharedInstance().cryptoSDKFeature, | |
feature.isEnabled && feature.needsVerificationUpgrade { |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## hotfix/1.10.7 #7454 +/- ##
================================================
Coverage ? 12.30%
================================================
Files ? 1645
Lines ? 162976
Branches ? 66914
================================================
Hits ? 20047
Misses ? 142280
Partials ? 649 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
27421e2
to
1ac47bc
Compare
Discussed the mechanism offline |
1ac47bc
to
8202617
Compare
Related SDK change matrix-org/matrix-ios-sdk#1751
Resolves https://github.com/vector-im/crypto-internal/issues/58
Display customized modal alert if upgrading from legacy to rust crypto and needing to verify the account.