No event decoration if no decryption result #7471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/event_shield
branch
from
198098d to
67ab9e4
Compare
Anderas
requested review from
a team and
stefanceriu
and removed request for
a team
Anderas
force-pushed
the
andy/event_shield
branch
from
67ab9e4 to
dfb4d7c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #7471 +/- ##
========================================
Coverage 12.29% 12.30%
========================================
Files 1645 1645
Lines 163147 163123 -24
Branches 66989 66973 -16
========================================
Hits 20066 20066
+ Misses 142431 142407 -24
Partials 650 650
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in objective-c event trust decoration, where the absence of event's
decryptionDecoration(i.e. it isnil) gets evaluated to0in a switch statement, which happens to be a red shield. ThedecryptionDecorationgets set pretty quickly after local echo but it does display a brief moment where a red shield is shown, even though it shoudn't be.To solve this add explicit `nill handling to objective-c, and also swap the order of decoration colors, so that 0 is none rather than red