Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display body in tombstone #18692

Open
benparsons opened this issue Aug 23, 2021 · 12 comments
Open

Display body in tombstone #18692

benparsons opened this issue Aug 23, 2021 · 12 comments
Labels
A-Room-Upgrades O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Product More input needed from the Product team

Comments

@benparsons
Copy link
Member

benparsons commented Aug 23, 2021

Your use case

What would you like to do?

If there is an body field available in the tombstone event, display it in place of the existing text.

Why would you like to it?

Because there may be a custom situation, where the normal text should be replaced.

How would you like to achieve it?

By honoring the body in the event.

Have you considered any alternatives?

No response

Additional context

No response

@anoadragon453
Copy link
Member

Note that this field is specced as "A server-defined message" - https://spec.matrix.org/unstable/client-server-api/#mroomtombstone

So yes, it definitely should be shown.

@SimonBrandner SimonBrandner added A-Room-Upgrades O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 23, 2021
@MadLittleMods MadLittleMods added the Z-Spec-Compliance An area where Element doesn't correctly implement the spec label Aug 23, 2021
@Palid Palid added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 25, 2021
@Palid
Copy link
Contributor

Palid commented Aug 25, 2021

Due to lack of spec compliance (and that it's pretty much frequent for all users) I'm bumping the priority up.

@Palid Palid added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 26, 2021
@Palid
Copy link
Contributor

Palid commented Aug 26, 2021

Moving down the priority after discussing with the team.

@turt2live
Copy link
Member

The spec doesn't require this to be shown by the way. It's meant as a fallback for clients which don't do custom handling

@turt2live turt2live removed the Z-Spec-Compliance An area where Element doesn't correctly implement the spec label Aug 26, 2021
@benparsons
Copy link
Member Author

The spec doesn't require this to be shown by the way. It's meant as a fallback for clients which don't do custom handling

True but it would still be useful for Element to be able to (optionally) show this.

@turt2live
Copy link
Member

Please not optionally 😭

Was just mentioning that the spec-compliance label was not correct - I personally think it should be shown (and has all kinds of use-cases for showing it).

@t3chguy t3chguy changed the title Display m.body in tombstone Display body in tombstone Oct 19, 2021
@t3chguy
Copy link
Member

t3chguy commented Oct 19, 2021

Are we sure we want this? In the "happy path" this would add a spurious This room has been replaced which cannot be i18n'd to default Synapse tombstones.

image

Which seems very duplicative of the existing (i18n'd) text

@t3chguy t3chguy added the X-Needs-Product More input needed from the Product team label Oct 19, 2021
@benparsons
Copy link
Member Author

I would still like to be able to override the text.

What about if in the absence of text we used the i18n'd fallback?

@turt2live
Copy link
Member

The server adds the text by default.

@t3chguy
Copy link
Member

t3chguy commented Oct 19, 2021

Yeah, the Synapse /upgrade API sets body to This room has been replaced without a way for the client to say not to, and it makes sense given the aforementioned purpose being

It's meant as a fallback for clients which don't do custom handling

@benparsons
Copy link
Member Author

So, to get this feature we would need to make changes on Synapse and on Element? I still think it's a reasonable request to be able to display a custom text here, and we have customers who have use-cases for it.

@t3chguy
Copy link
Member

t3chguy commented Oct 20, 2021

Well the issue is, any worthwhile change you make on Synapse would break backwards-compatibility for clients which don't have explicit m.room.tombstone support - the client has no way of discerning the "default" fallback backwards-compat message from a more specific one

@Johennes Johennes removed the Sponsored label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Upgrades O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Product More input needed from the Product team
Projects
None yet
Development

No branches or pull requests

8 participants