Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use light theme in all HTML chat exports #19117

Closed
nadonomy opened this issue Sep 21, 2021 · 2 comments
Closed

Use light theme in all HTML chat exports #19117

nadonomy opened this issue Sep 21, 2021 · 2 comments
Labels
A-Export-Chat A-Themes-Official Official themes (light, dark) O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Sep 21, 2021

Your use case

What would you like to do?

Once the new export chat feature merges, I would like it to apply the light theme in all cases, even if I'm using the dark theme in Element.

Why would you like to do it?

To have more confidence in printing, aid familiarity when sharing history with users not using dark themes.

Have you considered any alternatives?

I did consider whether this should be an option. Decided against as the export options are already complex, and it seems needless to add more complexity for something we can just be more resolute on.

Additional context

No response

@SimonBrandner SimonBrandner added A-Themes-Official Official themes (light, dark) O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 21, 2021
@germain-gg
Copy link
Contributor

germain-gg commented Sep 22, 2021

I believe using the media attribute on the <link/> tag we could honour the user's system theme using prefers-color-scheme.

And we would still be able to force the light theme using media="print" if a user wants to print a chat history.

Do you believe this could meet all the criterias to have your request fixed? Or are there other reasons for disabling the dark theme altogether?

@CicadaCinema
Copy link

It looks like this is implemented already - the HTML export uses the light theme, even if the dark theme is set in the client.

Exporting a chat — however you decide — will always include a Room summary, and appears in light mode (to save ink!).

from the blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Export-Chat A-Themes-Official Official themes (light, dark) O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants