Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-Type header is bogus on encrypted uploads, should be application/octet-stream or similar #24119

Closed
86dd opened this issue Dec 29, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9848
Closed

Content-Type header is bogus on encrypted uploads, should be application/octet-stream or similar #24119

86dd opened this issue Dec 29, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9848
Labels
A-E2EE A-File-Upload Attachments and file uploads A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@86dd
Copy link

86dd commented Dec 29, 2022

Steps to reproduce

  1. Try to upload a file in an encrypted chat on a server proxied by lighttpd using mod_proxy
  2. devtools

Outcome

What did you expect?

  1. File uploads and gets sent without any issue

What happened instead?

  1. Request errors with HTTP 400

Operating system

Debian testing

Browser information

LibreWolf 107.0.1

URL for webapp

https://chat.cat.casa

Application version

Element version: 1.11.17, Olm version: 3.2.12

Homeserver

https://matrix.cat.casa

Will you send logs?

Yes
@86dd 86dd added the T-Defect label Dec 29, 2022
@86dd
Copy link
Author

86dd commented Dec 29, 2022 •
edited
Loading

I have tested cinny, which sends a content-type header set to application/octet-stream and it appears to upload fine. Android SchildiChat also uploads fine.

@86dd
Copy link
Author

86dd commented Dec 29, 2022 •
edited
Loading

Element Web: In unencrypted rooms when a content-type header is sent it works fine

This was referenced Dec 29, 2022
Closed
Merged
@SimonBrandner SimonBrandner added A-E2EE A-Media A-File-Upload Attachments and file uploads S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-File-Upload Attachments and file uploads A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes empty content type during upload
Fixes empty content type during upload
2 participants
@SimonBrandner @86dd