Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline - Report Content #115

Closed
5 tasks done
stefanceriu opened this issue Jun 29, 2022 · 4 comments · Fixed by #659
Closed
5 tasks done

Timeline - Report Content #115

stefanceriu opened this issue Jun 29, 2022 · 4 comments · Fixed by #659
Assignees
Labels
X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-BBQ-Alpha Required for ElementX - BBQ - Alpha Z-BBQ-Beta Required for ElementX - BBQ - Beta

Comments

@stefanceriu
Copy link
Member

stefanceriu commented Jun 29, 2022

As an user I should be able to report malicious messages so that we can all have nice conversations

  • Message contextual report action
  • A way to specify the reason
  • Explain to the user what's happening when they report content
  • Give a visual feedback when the content has been sent successfully
  • Do not propose to report content for current user's own messages
@stefanceriu stefanceriu added Z-BBQ-Alpha Required for ElementX - BBQ - Alpha Z-User-Story labels Jun 29, 2022
@stefanceriu stefanceriu added Z-BBQ-Beta Required for ElementX - BBQ - Beta and removed Z-User-Story labels Oct 24, 2022
@Velin92 Velin92 linked a pull request Feb 16, 2023 that will close this issue
3 tasks
@jplatte jplatte self-assigned this Feb 16, 2023
@Velin92 Velin92 mentioned this issue Feb 16, 2023
3 tasks
@Velin92
Copy link
Member

Velin92 commented Feb 16, 2023

  • Explain to the user what's happening when they report content
  • Give a visual feedback when the content has been sent successfully

We need design and copies for these two

@jplatte jplatte added the X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue label Feb 16, 2023
@jplatte
Copy link
Contributor

jplatte commented Feb 16, 2023

In terms of the Rust code required for this, it should be as easy adding a method to this impl block (and importing matrix_sdk::ruma::api::client::room::report_content at the top of the file) that calls

RUNTIME.block_on(async move {
    self.room.client().send(report_content::v3::Request::new(/* ... */), None).await?;
    Ok(())
})

The function will have to return Result<()> like others in that impl block so a failure to send the request can be detected. Also the method needs to be added to api.udl.

@Velin92 Velin92 removed a link to a pull request Feb 17, 2023
3 tasks
@Velin92
Copy link
Member

Velin92 commented Feb 17, 2023

Will split this in two PRs:

In the first one we will only add the repot content functionality as it is also currently available on El-iOS, here it is:
#587
Which addresses:

  • Message contextual report action
  • A way to specify the reason
  • Do not propose to report content for current user's own messages

In the next one, once the designs are available we will add these two extra features:

  • Explain to the user what's happening when they report content
  • Give a visual feedback when the content has been sent successfully

@Velin92 Velin92 linked a pull request Mar 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue Z-BBQ-Alpha Required for ElementX - BBQ - Alpha Z-BBQ-Beta Required for ElementX - BBQ - Beta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants