Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC redirect sometimes fails to be picked up. #1936

Closed
pixlwave opened this issue Oct 23, 2023 · 1 comment · Fixed by #3461
Closed

OIDC redirect sometimes fails to be picked up. #1936

pixlwave opened this issue Oct 23, 2023 · 1 comment · Fixed by #3461
Assignees
Labels
A-OIDC O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect

Comments

@pixlwave
Copy link
Member

pixlwave commented Oct 23, 2023

Steps to reproduce

  1. Sign out of the app
  2. Choose a homeserver with OIDC configured
  3. Try to sign in to the app.

Outcome

What did you expect?

Sign in would complete.

What happened instead?

Sign in almost finishes, but instead of the redirect being picked up by the app, the ASWebAuthenticationSession navigates to the page (which doesn't exists so it 404s).

How to fix

  • Initially lets revert back to using io.element:/callback as the redirect URL, as the WAS handles the redirection itself and we know it works reliably. (done ✅)
  • As we would really like to use the universal link, we should host a fallback HTML page on http://mobile.element.io/ which opens up the app with the custom URI scheme. This will need additional parsing added to the URL routes on the app side.

Your phone model

N/A

Operating system version

iOS 17

Application version

1.3.4

Homeserver

No response

Will you send logs?

No

@pixlwave pixlwave added T-Defect S-Critical Prevents work, causes data loss and/or has no workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-OIDC labels Oct 23, 2023
@pixlwave pixlwave self-assigned this Oct 23, 2023
@pixlwave
Copy link
Member Author

Adding a note that iOS 17.4 deprecated the ASWebAuthenticationSession init with a scheme, replacing it with a URL: https://developer.apple.com/documentation/authenticationservices/aswebauthenticationsession/init(url:callback:completionhandler:)-6nut7

We should try this again as it sounds like we won't need the fallback page and can simply use the scheme on older devices and the URL on newer ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-OIDC O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant