-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing information elements in certain voice messages #2006
Comments
@Jaffex Do you happen to have an example file of one of the bridged voice messages you can share with us? From the event description something looks off as the filename is for an m4a file but the mimetype says it's an OGG file.
|
Media info from the file (sent privately):
So it is being converted correctly, but the filename is incorrect. |
As an addendum: I also use the mautrix-whatsapp bridge, which also provides voice messages. In those cases, the voice message shows the correct duration: But here, pressing the play-button does not start playback of the voice message. (There seems to be no way to listen to this message in Element X) These voice messages also play correctly in element-desktop and legacy element-ios. Here is the data for such a file:
(An example was provided to @pixlwave in a private chat) |
The file from the WhatsApp bridge is an OGG, however the sample rate isn't to spec, which states 48kHz. Not sure if thats hardcoded in our decoding somewhere so mentioning it in case.
|
I can confirm I also run WhatsApp Bridge and voice message does not play on element x iOS, but plays on Element X android, Element iOS and Element Web |
There are two issues here:
|
After migrating to the go rewrite of the mautrix signal bridge, I noticed that voice messages come through as Both of those filetypes trigger a player element on element desktop and legacy element app, but not in element x. In Element X, the only option is to open these files in a separate app to listen to them. Would it be possible to also add these file types to be playable with the voice message player? |
Steps to reproduce
I'm using the mautrix-signal bridge to talk to my signal contacts via matrix.
When a contact sends me a voice message on signal, this voice message gets sent as a voice message in matrix as well.
Outcome
What did you expect?
These voice messages show up in element desktop and the legacy element-ios client and have an indicator of
a) how long they are while they are not playing
b) how much time is left during playback
c) an indicator of where the current playback is via highlighting the waveform
Example from element-desktop
Example from element-desktop while playing back the bridged message
Everything is fine here.
I would expect this to be the same in element x.
What happened instead?
Voice messages that come via the signal bridge don't show how long they are, or where the playback is currently at while playing:
![image](https://private-user-images.githubusercontent.com/31133207/279662834-23ffbc07-2c3c-488d-80e7-4ae66a270e75.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDQ1NzQsIm5iZiI6MTczOTI0NDI3NCwicGF0aCI6Ii8zMTEzMzIwNy8yNzk2NjI4MzQtMjNmZmJjMDctMmMzYy00ODhkLTgwZTctNGFlNjZhMjcwZTc1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAzMjQzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRjMzc4Y2NiMGU3ODBkMmE5ZGU1YjI3Yzc3MjU4YTViNWFmYjViZGZmODNhOGQ2MmZlZDA2ZGM2ZjhlMTUyN2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cdQfagxlLF-JsvR60GRv5rHtJoyMwOCvBCAWC9UJBK0)
The same two voice messages from above, displayed in element x
This shows missing duration information for the bridged voice message.
Example from element x while playing back the bridged voice message
The indicator of the current playback position will remain at the start of the message during the entire playback.
The remaining time within the voice message stays at 0:00 during the entire playback.
Example from element x while playing back the voice message from element-desktop
Everything is fine here.
Additional Information
From what I can see while looking at the messages, the voice messages that come via the bridge are m4a format while the messages generated in element x or desktop are ogg.
I am aware that this might be an issue around how the bridge transmits the voice messages, but I thought it might be an issue for element x as well, since the other clients seem to be able to make sense of these voice messages' meta data.
Here is the message information for the bridged message:
Weird thing here is the mimetype, which says "audio/ogg", which might relate to the problem.
For comparison, here is the data for the element-desktop generated voice message:
Your phone model
iPhone 12 mini
Operating system version
iOS 17.1
Application version
1.4.0
Homeserver
Synapse
Will you send logs?
No
The text was updated successfully, but these errors were encountered: