Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics tracking for room creation #1100

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 17, 2023

This adds screen and event tracking for room and DM creation.

@github-actions
Copy link

github-actions bot commented Jun 17, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 39037ca

@Johennes Johennes force-pushed the johannes/create-room-analytics branch from 794af34 to a95dd7c Compare June 17, 2023 07:14
@Johennes Johennes marked this pull request as ready for review June 17, 2023 07:16
@Johennes Johennes requested a review from a team as a code owner June 17, 2023 07:16
@Johennes Johennes requested review from pixlwave and removed request for a team June 17, 2023 07:16
@Johennes
Copy link
Contributor Author

CC @giomfo because I think you might have had this on your list, too.

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (1f65b7b) 43.16% compared to head (39037ca) 43.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1100      +/-   ##
===========================================
- Coverage    43.16%   43.15%   -0.02%     
===========================================
  Files          385      385              
  Lines        24284    24291       +7     
  Branches     12773    12774       +1     
===========================================
  Hits         10482    10482              
- Misses       13522    13529       +7     
  Partials       280      280              
Flag Coverage Δ
unittests 23.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...urces/Screens/CreateRoom/CreateRoomViewModel.swift 42.53% <0.00%> (-0.32%) ⬇️
...ces/Screens/CreateRoom/View/CreateRoomScreen.swift 0.00% <0.00%> (ø)
...ens/StartChatScreen/StartChatScreenViewModel.swift 44.34% <0.00%> (-0.39%) ⬇️
...Screens/StartChatScreen/View/StartChatScreen.swift 68.51% <0.00%> (-0.65%) ⬇️
...lementX/Sources/Services/Analytics/Analytics.swift 81.35% <0.00%> (-4.36%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, its good to see PostHog starting to be used!

ElementX/Sources/Services/Analytics/Analytics.swift Outdated Show resolved Hide resolved
@Johennes Johennes force-pushed the johannes/create-room-analytics branch from a95dd7c to 6ff816c Compare June 19, 2023 11:12
@Johennes Johennes requested a review from pixlwave June 19, 2023 11:13
@Johennes Johennes force-pushed the johannes/create-room-analytics branch from 6ff816c to 2bc0147 Compare June 19, 2023 11:13
@Johennes Johennes force-pushed the johannes/create-room-analytics branch from 2bc0147 to 39037ca Compare June 19, 2023 11:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@giomfo giomfo mentioned this pull request Jun 19, 2023
5 tasks
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@pixlwave pixlwave merged commit ee643f7 into develop Jun 19, 2023
@pixlwave pixlwave deleted the johannes/create-room-analytics branch June 19, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants