-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace FilePreviewScreen with InteractiveQuickLook. #1187
Conversation
afbd022
to
06e730b
Compare
Generated by 🚫 Danger Swift against d2f016d |
- Allows full screen presentation. - Allows dismiss gesture to work. - Presentation looks much better on macOS.
06e730b
to
d2f016d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1187 +/- ##
===========================================
- Coverage 41.95% 41.86% -0.10%
===========================================
Files 403 404 +1
Lines 25522 25547 +25
Branches 13305 13304 -1
===========================================
- Hits 10709 10694 -15
- Misses 14518 14558 +40
Partials 295 295
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Very cool! 😎
This PR updates media previews to work as expected in a messaging app.
Note: The coordinator and view models have gone.
quickLookPreview(_:)
in iOS 17.What this PR doesn't do: Provide a frame/view for as a transition source for the presentation.
Mac
Screen.Recording.2023-06-27.at.6.25.30.pm.mov