Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default schemes for detected links that don't have any #1651

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add default schemes for detected links that don't have any #1651

merged 1 commit into from
Sep 7, 2023

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner September 7, 2023 09:14
@stefanceriu stefanceriu requested review from alfogrillo and removed request for a team September 7, 2023 09:14
@stefanceriu stefanceriu force-pushed the stefan/defaultLinkSchemes branch from 34f0f9c to c4d42a7 Compare September 7, 2023 09:15
@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 2d2dfe8

@stefanceriu stefanceriu force-pushed the stefan/defaultLinkSchemes branch from c4d42a7 to 4975e8f Compare September 7, 2023 09:25
pixlwave
pixlwave approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu enabled auto-merge (rebase) September 7, 2023 09:27
@stefanceriu stefanceriu force-pushed the stefan/defaultLinkSchemes branch from 4975e8f to 2d2dfe8 Compare September 7, 2023 09:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu disabled auto-merge September 7, 2023 11:56
@stefanceriu stefanceriu merged commit 29b2b7f into develop Sep 7, 2023
@stefanceriu stefanceriu deleted the stefan/defaultLinkSchemes branch September 7, 2023 11:56
@HarHarLinks HarHarLinks mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@alfogrillo alfogrillo Awaiting requested review from alfogrillo alfogrillo is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave