-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DesignKit: Update design tokens and create ElementColors locally. #186
Conversation
Generated by 🚫 Danger Swift against 35239fe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Codecov ReportBase: 12.71% // Head: 12.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #186 +/- ##
===========================================
- Coverage 12.71% 12.54% -0.18%
===========================================
Files 194 197 +3
Lines 12562 12749 +187
Branches 6063 6176 +113
===========================================
+ Hits 1597 1599 +2
- Misses 10925 11110 +185
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nUFVVL |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Surprisingly, with the change of accent colour, the first few UI tests I ran locally all passed. Will merge this and see what happens in the morning 🔍 |
The latest version of element-design-tokens removes the
.element
static property onColor
/UIColor
and renames the exported colours asCompoundColors
. The.global
property is still available.This PR updates the version of the tokens consumed, and creates
ElementColors
locally in DesignKit to add the system colours that are in the Figma.This is likely a temporary set up until colours and Compound in general are better defined.