Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DesignKit: Update design tokens and create ElementColors locally. #186

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 14, 2022

The latest version of element-design-tokens removes the .element static property on Color/UIColor and renames the exported colours as CompoundColors. The .global property is still available.

This PR updates the version of the tokens consumed, and creates ElementColors locally in DesignKit to add the system colours that are in the Figma.

This is likely a temporary set up until colours and Compound in general are better defined.

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 35239fe

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 12.71% // Head: 12.54% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (f865e11) compared to base (dd23857).
Patch coverage: 2.70% of modified lines in pull request are covered.

❗ Current head f865e11 differs from pull request most recent head 35239fe. Consider uploading reports for the commit 35239fe to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #186      +/-   ##
===========================================
- Coverage    12.71%   12.54%   -0.18%     
===========================================
  Files          194      197       +3     
  Lines        12562    12749     +187     
  Branches      6063     6176     +113     
===========================================
+ Hits          1597     1599       +2     
- Misses       10925    11110     +185     
  Partials        40       40              
Impacted Files Coverage Δ
DesignKit/Sources/Colors/ElementColors.swift 2.70% <2.70%> (ø)
...mentX/Sources/Generated/Strings+Untranslated.swift 50.00% <0.00%> (-50.00%) ⬇️
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 0.00% <0.00%> (ø)
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 0.00% <0.00%> (ø)
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 0.00% <0.00%> (ø)
...rces/Screens/RoomScreen/View/MessageComposer.swift 0.00% <0.00%> (ø)
...ces/Screens/RoomScreen/View/TimelineItemList.swift 0.00% <0.00%> (ø)
...ces/Services/Timeline/RoomTimelineController.swift 0.00% <0.00%> (ø)
...Services/Timeline/MockRoomTimelineController.swift 0.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/nUFVVL

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave
Copy link
Member Author

Surprisingly, with the change of accent colour, the first few UI tests I ran locally all passed. Will merge this and see what happens in the morning 🔍

@pixlwave pixlwave merged commit bc45795 into develop Sep 14, 2022
@pixlwave pixlwave deleted the doug/design-colours branch September 14, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants