DesignKit: Update fonts to match Figma. #187
Conversation
pixlwave
force-pushed
the
doug/fonts
branch
from
bdede76 to
897466d
Compare
Generated by 🚫 Danger Swift against 284ceb6 |
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gu5B5h |
Codecov ReportBase: 12.54% // Head: 12.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #187 +/- ##
===========================================
+ Coverage 12.54% 12.57% +0.03%
===========================================
Files 197 197
Lines 12749 12717 -32
Branches 6176 6167 -9
===========================================
Hits 1599 1599
+ Misses 11110 11078 -32
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Whoops, I was wrong about #186 not failing snapshots... I tested them with the wrong device. All updated in this PR. |
pixlwave
requested review from
a team and
ismailgulek
and removed request for
a team
Following on from #186, this PR updates the fonts in DesignKit to match the Figma (all semi-bold's are now bolds).
It seemed to make more sense to me to simplify the base fonts and apply the weight modifiers during the SwiftUI/UIKit font structs creation, but happy to revert if that doesn't seem sensible. Also, yes I chickened out of removing the
boldvariants - mainly because having these made the refactor really easy which I think is reason enough to keep them :)