Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation for AppLockSetupFlowCoordinator. #1949

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Initial implementation for AppLockSetupFlowCoordinator. #1949

merged 5 commits into from
Oct 25, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 24, 2023 •
edited
Loading

This PR contains 2 commits:

  • Add an AppLockSetupFlowCoordinator which is presented either as part of the authentication flow (when the PIN is mandatory) or from the Settings screen (when the PIN is optional). This commit also renames AppLockSettingsScreen to AppLockSetupSettingsScreen.
  • Implement the forceLogout action to when the user has entered their PIN incorrectly 3 times.

@pixlwave pixlwave added the Trigger-PR-Build Uses to trigger alpha builds for PRs label Oct 24, 2023
@pixlwave pixlwave force-pushed the doug/app-lock-setup-flow branch from ee1858e to 4169c2f Compare October 24, 2023 10:52
@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 435f63b

@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/uUiTAY

@pixlwave pixlwave force-pushed the doug/app-lock-setup-flow branch 3 times, most recently from 22c7c1c to 3bcd98d Compare October 25, 2023 09:25
@pixlwave pixlwave marked this pull request as ready for review October 25, 2023 09:25
@pixlwave pixlwave requested a review from a team as a code owner October 25, 2023 09:25
@pixlwave pixlwave requested review from nimau and removed request for a team October 25, 2023 09:25
@pixlwave pixlwave force-pushed the doug/app-lock-setup-flow branch from 40ffa29 to dc22869 Compare October 25, 2023 09:28
nimau
nimau approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pixlwave pixlwave force-pushed the doug/app-lock-setup-flow branch from a116693 to 435f63b Compare October 25, 2023 10:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 25, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave enabled auto-merge (squash) October 25, 2023 10:45
@pixlwave pixlwave merged commit c6e4dc2 into develop Oct 25, 2023
@pixlwave pixlwave deleted the doug/app-lock-setup-flow branch October 25, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimau nimau nimau approved these changes

Assignees
No one assigned
Labels
Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @nimau