Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show the call button on macOS #2064

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Don't show the call button on macOS #2064

merged 2 commits into from
Nov 13, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 10, 2023 •
edited
Loading

Calls don't work in the web view on macOS and currently clicking the button shows you both the error, and for some reason, redirects you to FaceTime 🙃

Note: CI failures handled in #2067.

@pixlwave
Don't show the call button on macOS
d0a042f 
Calls don't work in the web view on macOS.
@pixlwave pixlwave requested a review from stefanceriu November 10, 2023 16:54
@pixlwave pixlwave requested a review from a team as a code owner November 10, 2023 16:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3c1e22c

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nimau
nimau approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stefanceriu
stefanceriu approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too 👍

@pixlwave pixlwave enabled auto-merge (squash) November 13, 2023 07:32
@pixlwave pixlwave disabled auto-merge November 13, 2023 07:32
@pixlwave pixlwave merged commit 61af01e into develop Nov 13, 2023
@pixlwave pixlwave deleted the doug/disable-ec-on-macos branch November 13, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimau nimau nimau approved these changes

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pixlwave @stefanceriu @nimau