Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup tracing with a typed configuration. #336

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 24, 2022

This change allows us to create tracing presents so that its easier to increase the logging as needed.

I've also added the RUST_BACKTRACE env var to the run scheme (but disabled by default) as that seems like it would be useful to easily toggle on and off.

@github-actions
Copy link

github-actions bot commented Nov 24, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 559655a

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 34.30% // Head: 32.04% // Decreases project coverage by -2.25% ⚠️

Coverage data is based on head (cc54df2) compared to base (f776575).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head cc54df2 differs from pull request most recent head 559655a. Consider uploading reports for the commit 559655a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #336      +/-   ##
===========================================
- Coverage    34.30%   32.04%   -2.26%     
===========================================
  Files          233      269      +36     
  Lines        15043    17764    +2721     
  Branches      8680     9759    +1079     
===========================================
+ Hits          5160     5693     +533     
- Misses        9736    11894    +2158     
- Partials       147      177      +30     
Flag Coverage Δ
unittests 13.61% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 13.11% <100.00%> (-2.22%) ⬇️
ElementX/Sources/Other/Logging/RustTracing.swift 100.00% <100.00%> (ø)
...mentX/Sources/UITests/UITestsRootCoordinator.swift 0.00% <0.00%> (-100.00%) ⬇️
...Screens/OnboardingScreen/OnboardingViewModel.swift 0.00% <0.00%> (-100.00%) ⬇️
...Notifications/MockUserNotificationController.swift 0.00% <0.00%> (-100.00%) ⬇️
.../UserNotifications/UserNotificationPresenter.swift 0.00% <0.00%> (-94.74%) ⬇️
...reens/OnboardingScreen/OnboardingCoordinator.swift 0.00% <0.00%> (-93.75%) ⬇️
...nboardingScreen/View/OnboardingPageIndicator.swift 0.00% <0.00%> (-89.48%) ⬇️
...s/Screens/RoomScreen/View/TimelineScrollView.swift 0.00% <0.00%> (-87.50%) ⬇️
...es/Screens/OnboardingScreen/OnboardingModels.swift 0.00% <0.00%> (-86.85%) ⬇️
... and 129 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave force-pushed the doug/tracing branch 4 times, most recently from 56ab9b6 to 50c5ee5 Compare November 25, 2022 15:38
@pixlwave pixlwave marked this pull request as ready for review November 25, 2022 15:58
@pixlwave pixlwave requested a review from stefanceriu November 25, 2022 15:59
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ah-mazing, nicely done 👍

@stefanceriu stefanceriu enabled auto-merge (rebase) November 28, 2022 07:17
@stefanceriu stefanceriu disabled auto-merge November 28, 2022 07:17
@stefanceriu stefanceriu enabled auto-merge (rebase) November 28, 2022 07:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit 198127c into develop Nov 28, 2022
@stefanceriu stefanceriu deleted the doug/tracing branch November 28, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants