Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide scroll down button VoiceOver #670

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Hide scroll down button VoiceOver #670

merged 2 commits into from
Mar 6, 2023

Conversation

sempruijs
Copy link
Contributor

@sempruijs sempruijs commented Mar 3, 2023

The scroll down button was still intractable when it was hidden for visual users. This pr fixes that by hiding the button if it is hidden for visual users.

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sempruijs
Copy link
Contributor Author

Signed-off-by: Sem Pruijs [email protected]

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (eed031c) 51.68% compared to head (4eacb49) 51.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #670      +/-   ##
===========================================
- Coverage    51.68%   51.68%   -0.01%     
===========================================
  Files          263      263              
  Lines        14310    14311       +1     
  Branches      9133     9133              
===========================================
  Hits          7396     7396              
- Misses        6691     6692       +1     
  Partials       223      223              
Flag Coverage Δ
unittests 20.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 68.23% <0.00%> (-0.82%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanceriu stefanceriu self-requested a review March 6, 2023 07:33
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you! 👍

@stefanceriu stefanceriu merged commit 25aa696 into element-hq:develop Mar 6, 2023
@sempruijs sempruijs deleted the sempruijs/hide-scroll-down-voiceover branch March 6, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants