Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change name to nil in direct room parameters #758

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

flescio
Copy link
Contributor

@flescio flescio commented Apr 3, 2023

The name of a direct room should be nil in order to reflect the other participant.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against bb3f700

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flescio flescio marked this pull request as ready for review April 3, 2023 15:03
@flescio flescio requested a review from a team as a code owner April 3, 2023 15:03
@flescio flescio requested review from pixlwave and removed request for a team April 3, 2023 15:03
@flescio flescio enabled auto-merge (squash) April 3, 2023 15:03
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0f858d9) 50.80% compared to head (bb3f700) 50.80%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #758   +/-   ##
========================================
  Coverage    50.80%   50.80%           
========================================
  Files          292      292           
  Lines        15995    15995           
  Branches      9731     9731           
========================================
  Hits          8127     8127           
  Misses        7629     7629           
  Partials       239      239           
Flag Coverage Δ
unittests 25.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ElementX/Sources/Services/Client/ClientProxy.swift 41.34% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@flescio flescio merged commit b089cd6 into develop Apr 3, 2023
@flescio flescio deleted the flescio/create-room-name-parameter branch April 3, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants