Guard user suggestions behind feature flag so that they don't impact releasability of other room creation features #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johennes
requested review from
pixlwave and
alfogrillo
and removed request for
a team and
pixlwave
Generated by 🚫 Danger Swift against fa78a30 |
…releasability of other room creation features
Johennes
force-pushed
the
johannes/put-suggestions-behind-feature-flag
branch
from
f57fe51 to
614956d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #770 +/- ##
===========================================
- Coverage 51.29% 51.20% -0.09%
===========================================
Files 290 290
Lines 16008 16025 +17
Branches 9734 9744 +10
===========================================
- Hits 8211 8206 -5
- Misses 7557 7580 +23
+ Partials 240 239 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
alfogrillo
approved these changes
Apr 5, 2023
pixlwave
approved these changes
Apr 5, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions have been descoped from element-hq/element-meta#988. This wraps them into a separate feature switch so that we can still safely release other pieces of the epic.