Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact should be called 'remove' to match riot/web #2134

Closed
ara4n opened this issue Dec 16, 2018 · 3 comments
Closed

Redact should be called 'remove' to match riot/web #2134

ara4n opened this issue Dec 16, 2018 · 3 comments
Labels
P3 parity-with-web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@ara4n
Copy link
Member

ara4n commented Dec 16, 2018

No description provided.

@aaronraimist
Copy link
Contributor

aaronraimist commented Dec 17, 2018 •
edited
Loading

Meta issue:
element-hq/riot-meta#238

Related Android issue:
element-hq/riot-android#2752

@manuroe manuroe added this to the Sprint 17 milestone Jan 3, 2019
@manuroe manuroe changed the title redact should be called 'remove' to match riot/web, and show placeholder redacted msg bubbles as per web redact should be called 'remove' to match riot/web Jan 16, 2019
@manuroe
Copy link
Member

manuroe commented Jan 16, 2019

I have moved the part "show placeholder redacted msg bubbles as per web" of the initial issue to #2180.

@manuroe manuroe added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements P3 parity-with-web parity-with-android labels Jan 16, 2019
@manuroe manuroe changed the title redact should be called 'remove' to match riot/web Redact should be called 'remove' to match riot/web Jan 16, 2019
@manuroe manuroe mentioned this issue Jan 16, 2019
Closed
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Jan 16, 2019
@manuroe
Chat screen: Redact has been renamed to Remove to match riot/web
4da7ee9 
element-hq/element-ios/issues/2134
manuroe added a commit that referenced this issue Jan 16, 2019
@manuroe
RoomVC: Redact has been renamed to Remove to match riot/web
64febce 
#2134
@manuroe
Copy link
Member

manuroe commented Jan 16, 2019

Fixed by 64febce & matrix-org/matrix-ios-kit@4da7ee9

@manuroe manuroe closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 parity-with-web T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @aaronraimist @manuroe