Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify route transform's component_discarded_events_total #14073

Closed
2 tasks
Tracked by #14061
JeanMertz opened this issue Aug 23, 2022 · 1 comment
Closed
2 tasks
Tracked by #14061

verify route transform's component_discarded_events_total #14073

JeanMertz opened this issue Aug 23, 2022 · 1 comment
Assignees

Comments

@JeanMertz
Copy link
Contributor

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
@JeanMertz
Copy link
Contributor Author

I realized that this issue doesn't need to be resolved, as (1) there's no way for this transform to discard events, so component_discarded_events_total is never emitted, and (2) because of that, we don't need to use assert_X_compliance, as we're already using the COMPONENT_MULTIPLE_OUTPUTS_TESTS test specification which is specifically made for components that emit multiple events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant