Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify datadog_archives sink #14172

Closed
3 tasks
Tracked by #13995
neuronull opened this issue Aug 30, 2022 · 1 comment
Closed
3 tasks
Tracked by #13995

Verify datadog_archives sink #14172

neuronull opened this issue Aug 30, 2022 · 1 comment
Assignees
Labels
sink: datadog_archives Anything `datadog_archives` sink related

Comments

@neuronull
Copy link
Contributor

neuronull commented Aug 30, 2022

  • Verify internal event processing metrics are tested via assert_X_compliance test helpers
  • Update component_discarded_events_total to match the new instrumentation spec by adding reason to the emitted logs, and intentional to emitted logs and metrics
  • Verify that the component correctly emits the correct error events per the component spec
@neuronull
Copy link
Contributor Author

This comment suggests that the assertion to compliance may not be a simple task.

// NOTE: We intentionally do not assert/verify that `datadog_archives` meets the component specification because it
// derives all of its capabilities from existing sink implementations which themselves are tested. We probably _should_
// also verify it here, but for now, this is a punt to avoid having to add a bunch of specific integration tests that
// exercise all possible configurations of the sink.

@tobz indicates that this sink is currently inert and can be ignored for the moment, so will not attempt to undertake the above.

In terms of the rest of the audit- the AWS S3, Azure Blob, and GCP CS sinks are all independently tracked already.

As such, I will mark this as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: datadog_archives Anything `datadog_archives` sink related
Projects
None yet
Development

No branches or pull requests

1 participant