Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl-src-rs problem with vendored source #18339

Closed
happysalada opened this issue Aug 22, 2023 · 4 comments
Closed

openssl-src-rs problem with vendored source #18339

happysalada opened this issue Aug 22, 2023 · 4 comments
Labels
type: feature A value-adding code addition that introduce new functionality.

Comments

@happysalada
Copy link

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

Hi, in nixos for the sake of reproducibility dependencies are vendored.
With the latest 0.32 release, the vendored build fails with

 error: failed to load source for dependency `openssl-src`
vector>
vector> Caused by:
vector>   Unable to update https://github.com/vectordotdev/openssl-src-rs.git?tag=releas
e-300-force-engine+3.1.2
vector>
vector> Caused by:
vector>   the source https://github.com/vectordotdev/openssl-src-rs.git?tag=release-300-
force-engine+3.1.2 requires a lock file to be present first before it can be
vector>   used against vendored source code
vector>
vector>   remove the source replacement configuration, generate a lock file, and then
vector>   restore the source replacement configuration to continue the build

reading a bit in the cargo.toml, you are using a patched openssl-src to get 3.1 instead of 1.1
I'm just wondering if there is a way to upstream those changes ?

Attempted Solutions

Currently vector can't be updated anymore on nixos, I wanted to use this issue to brainstorm some potential solutions.

Proposal

No proposal yet, hopefully we can figure it out in this issue.

References

No response

Version

0.32.1

@happysalada happysalada added the type: feature A value-adding code addition that introduce new functionality. label Aug 22, 2023
@jszwedko
Copy link
Member

jszwedko commented Aug 22, 2023

This looks like a similar issue: nix-community/naersk#173 . It's not clear to me why it only started hitting it for the openssl-src crate and not the other overrides that are in there though 🤔

@jszwedko
Copy link
Member

I wonder if this could also be related to rust-lang/cargo#11085

@happysalada
Copy link
Author

likewise, it's weird that this is starting to happen right now.
The issue you refered to on cargo , should be fixed with 1.73
I'll report back after rust is updated to see if that fixes anything.

@dsmith3197
Copy link
Contributor

The patch will be removed in the next Vector release (v0.33.0). #18609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants