Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remap-lang: serialize timestamp value in RFC3339 #5677

Closed
fanatid opened this issue Dec 22, 2020 · 2 comments · Fixed by #6353
Closed

remap-lang: serialize timestamp value in RFC3339 #5677

fanatid opened this issue Dec 22, 2020 · 2 comments · Fixed by #6353
Assignees
@JeanMertz
Labels
domain: vrl Anything related to the Vector Remap Language type: enhancement A value-adding code change that enhances its existing functionality.
Milestone
2021-02-01 D-Fuel

Comments

@fanatid
Copy link
Contributor

fanatid commented Dec 22, 2020

Initial discussion: #5653 (comment)
@fanatid fanatid added type: enhancement A value-adding code change that enhances its existing functionality. needs: approval Needs review & approval before work can begin. domain: vrl Anything related to the Vector Remap Language labels Dec 22, 2020
@fanatid fanatid mentioned this issue Dec 22, 2020
Merged
@binarylogic binarylogic removed the needs: approval Needs review & approval before work can begin. label Dec 26, 2020
@binarylogic
Copy link
Contributor

cc @JeanMertz and @FungusHumungus for input/approval.

@binarylogic binarylogic added this to the 2021-01-04 Xenomass Well milestone Dec 26, 2020
@jamtur01 jamtur01 removed this from the 2021-01-04 Xenomass Well milestone Jan 1, 2021
@binarylogic binarylogic added this to the 2021-01-18 Tabula E-Rasa milestone Jan 15, 2021
@JeanMertz
Copy link
Contributor

I agree. This was an oversight on my part, as I expected DateTime<UTC>'s Display impl to actually result in an RFC3339 formatted string.

@JeanMertz JeanMertz assigned JeanMertz and unassigned StephenWakely Jan 27, 2021
@JeanMertz JeanMertz mentioned this issue Feb 6, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeanMertz JeanMertz

Labels
domain: vrl Anything related to the Vector Remap Language type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
2021-02-01 D-Fuel
Development

Successfully merging a pull request may close this issue.

chore(remap): re-implement VRL parser/compiler vectordotdev/vector
5 participants
@jamtur01 @StephenWakely @JeanMertz @binarylogic @fanatid